Adam M• 550
@AdamMzkr
Submitted
This was relatively easy around 2h and was done. I used CSS grid and flexbox to finish this challenge.
All comments appreciate :)
Adam M
@AdamMzkr
All comments
- Adam M• 550
@AdamMzkr
Posted
Thanks but I used some of semantic tags like main footer section. But I meet to put more focus on this next Time
0 - stefansnaerh• 90
@stefansnaerh
Submitted
Timetracker using CSS GRID and REACT. Very happy to be learning grid, hope you enjoy!
Adam M• 550@AdamMzkr
Posted
Nice solution but: -no images in the header of sections (background-image) -no alt text to images Anyway, really good work :)
1 - Rodrigo Zapatero• 50
@rodriwaw
Submitted
I want to know how to properly structure a CSS stylesheet, I'm sure I commited a lot of mistakes in that part of the challenge.
Adam M• 550@AdamMzkr
Posted
good solution, but i think its to low padding in all messages if you add some padding will look so better:)
Marked as helpful
0 - Ron Paolo Toyhacao• 165
@rontoyhacao
Submitted
Helloo good day! This challenge took me some time to finish because I wanted to make it have a credit card validation and it's unfortunate that I wasn't able to find out sooner that a credit card validator library exists from npm and I had to do it the hard way that's why it took me so long. I had to look up for solutions online particularly on stackoverflow. I would like to give huge thanks to the people from stackoverflow for the resources I got. I was able to learn and have some idea about libraries and packages along the way. Please feel free to give some feedback and I would appreciate it. Thankyouuu. 💕
Adam M• 550@AdamMzkr
Posted
hi, pefect solution and this smooth animated and validated card number amazing!!
1 - Adam M• 550
@AdamMzkr
Submitted
Hi this is my next solution after short break:) It's responsive and quite look like the design. I used simple css and flexbox, for icons i used the "font awesome kit".
If you see some thing to fix or improve in this website I will really appreciate.
Adam M• 550@AdamMzkr
Posted
Thank' s a loot for your comment. I know about breakpoints but i don't focus on it. I want to finish all newbie level challenges.( I FINISHED 17 chellenges) and in the next level I will more focus on all aspect of design. But your comment it's really important for me, because you are experience user.👋. I am still amateur 😉.
0 - Felix• 70
@felix-toledo
Submitted
So I changed this challenge because I am learning JS and I wanted to make some things that I needed to improve and learn.
I'm starting with JS so I know that some things won't be ok.
Adam M• 550@AdamMzkr
Posted
GOOD job, but you need to learn about form validation and validate form. Focus more abut placing elements in form (flexbox) Anyway nice solution:) You miss Id for labels and language rule in HTML(head).
Marked as helpful
1 - Mohamed Khaled• 190
@mohamedKhaled89
Submitted
This is my solution for the Huddle landing page.
- Feel free to leave any feedback about my solution.
Adam M• 550@AdamMzkr
Posted
Good Job but, in mobile view your design as a little bit to big. To see all content you need to scroll horizontally. I think change width container to 90% will help.
Marked as helpful
1 - Eduardo• 910
@KTrick01
Submitted
Hi! I wanted to do this challenge to practice working with JSON archives, I learned a lot from this, even though it is relatively simple looking. Every value of the chart is being pulled from the JSON file so I think I did accomplish the bonus tip of the challenge? I'm not sure if See dynamically generated bars means an animation of the bars rising or it means that the chart changes based on the values of the JSON (That's what I did), anyway, I'm happy with what I did!
PD: Tomorrow we wil see if the current day bar changes like it's supposed to do
PD2: Yes it does
Adam M• 550@AdamMzkr
Posted
Hi GREAT job! nice looking smooth and nice animation. Only some HTML issues to fix :)
1 - Paul• 30
@hrjuny
Submitted
I use grid for the whole lay out and flex for the positioning. I struggle a bit with media query but I managed to pull it off.
Adam M• 550@AdamMzkr
Posted
Nice solution but, it's some bugs in report check this and fix. Change div <attribution> for <footer> for example:)
Marked as helpful
0 - Daniel Chyliński• 160
@danielosd68
Submitted
I think this project is the best project I've ever done. 😁
Adam M• 550@AdamMzkr
Posted
Really nice solution! Only what you can change is add semantic tags instead div's ;)
Marked as helpful
0 - Ekure Edem• 260
@astraldev
Submitted
I'm finding it difficult to make my HTML very accessible...
Open to any suggestions and ideas.
Adam M• 550@AdamMzkr
Posted
Hi, You forgot main element and H1 tag. When you add this accessibility errors will gone.
Anyway good job💪
0 - Mohamed Adel• 10
@mohamedAbouzid
Submitted
Adam M• 550@AdamMzkr
Posted
Hi, it's something wrong with your mobile view check these and fix. Your card in mobile view have too small width. And it's no sense to make a new css file to display mobile view if this css file contains 1 line of code
I hope it will be helpfull
Marked as helpful
1 - Andrew Festa• 50
@afesta12
Submitted
My solution feels quite a bit 'hacky', which is the best word I could come up with.
I could not get things to line up correctly using flex, so I switched the layout between flex and grid during a media query, which I'm assuming is not a best practice solution.
I did learn a bit about displaying different images, but is there a preferred method to doing this? Display none seemed to work, but I also read about people using a background image.
Thank you, and any feedback is highly appreciated! =)
Adam M• 550@AdamMzkr
Posted
Hi i finished this challenge only use flexbox, i use @media and in desktop( mobile first) view i only change of size divs with % and flex-direction. I don't use a PX to resize element, I use em and rem.
I hope it will be helpfull;)
1
