Skip to content
OverviewSolutions
16
Comments
15
Ahlam
@AhlamAb22

All comments

  • Ahlam•300
    @AhlamAb22

    Multiplication does not work

  • Ahlam•300
    @AhlamAb22

    Good work Richard!

    I have one suggestion, "HTML & CSS foundations" is clickable, and clickable items should be either a button or an anchor depending on the action :)

  • Ahlam•300
    @AhlamAb22

    Good work!

    Here are a few suggestions:

    -Try to use classes for styling instead of directly styling elements.

    -Implement a CSS reset.

    -Avoid using Px for font-size

    -Avoid specifying fixed heights and widths; try using 'max-height' and 'max-width' for flexibility.

    Marked as helpful
  • Ahlam•300
    @AhlamAb22

    As @techyjc said, you need to define :root instead of repeating the size each time. but you are right about rem, it is not recommended to use px

  • Ahlam•300
    @AhlamAb22

    Good work!

    Here are a few suggestions:

    -You don't need an extra <div>, you can wrap the whole content with one <div>

    -Implement a CSS reset.

    -Use em or rem for font-size instead of px

    -Avoid specifying fixed heights and widths; try using 'max-height' and 'max-width' for flexibility.

    Marked as helpful
  • Ahlam•300
    @AhlamAb22

    Great work! I assume this should be <a> instead of <h2> because it's clickable.

    Also, consider using rem or em instead of px for font-size.

  • Ahlam•300
    @AhlamAb22

    You can use <s> for the old price and also it's better to add some visually hidden text for the old price and the current price for screenreaders users

    Marked as helpful
  • Ahlam•300
    @AhlamAb22

    Which edge do you mean?

  • Ahlam•300
    @AhlamAb22

    Good start! Here are a few suggestions:

    -Consider using 'justify-content: center;' to center the card on the page.

    -Try to use classes for styling instead of directly styling elements.

    -Implement a CSS reset.

    -Avoid specifying fixed heights and widths; try using 'max-height' and 'max-width' for flexibility.

    Marked as helpful
  • Ahlam•300
    @AhlamAb22

    Actually, it's enough to have a background-color and then use mix-blend-mode: multiply; and then control the opacity

  • Ahlam•300
    @AhlamAb22

    I have some suggestions based on advice I received from other developers:

    -Use classes for elements like h2, p, etc. Consider applying different styles across the entire website if needed.

    -Implement a CSS reset.

    -Avoid using pixels for font-size.

    -Consider using 'display: flex', 'justify-content', and 'align-items: center' for the body to center the box.

    Marked as helpful
  • Ahlam•300
    @AhlamAb22

    Great job on your work! I have a few notes to share. I'm also in the process of learning and addressing past challenges to reach best practices. Here's some feedback I received that might be helpful to you:

    -It's recommended to have only one h1 per page. For this task, consider using h2 headings for 'Sedans,' 'SUVs,' and 'Luxury.'

    -Instead of using buttons, consider using anchors as these will navigate to other pages.

    -Incorporating landmarks such as 'Main' and 'Footer' would improve the page's accessibility and structure.

  • Ahlam•300
    @AhlamAb22

    How did you determine the image size? It appears identical to the challenge

  • Ahlam•300
    @AhlamAb22

    I tried to find the source code but it is not available. Can you please share it with me?

  • Ahlam•300
    @AhlamAb22

    Great work! you can also remove the buttons' borders to match the design

    Marked as helpful