Hi! I'm a self-taught fronted/backend developer with a unstoppable hanger to create cool things with web based technologies, such as HTML, CSS & JS for frontend developement. As well as, PHP and MySQL for backend developement.
I’m currently learning...I learn new things every day, right now I'm focusing a lot in UX/UI design using Figma as my design tool. Best designing tool ever! Of course, I keep developing things with the technologies I mentioned but lately my focus has only been UX/UI design.
Latest comments
- @B1N4R1@B1N4R1
Thanks to the three of you: Lucas, David and PhoenixDev22
I took your suggestions into account and applied them to the challenge. Most of them are things that I already knew but forgot to apply them 😅, like the
main
andfooter
landmarks or the margin for the container.As Lucas pointed out, the
div.desk
element was clearly needless so I removed it and used flex's gap property to add some spacing between the elements.Again thanks for the feedback!
- @mayanhavoc@B1N4R1
Hey Roberto!
Firstly congrats on completing the challenge! Your solution looks good!
Here some pointers:
- You should really get rid of the
min-width: 1440px
in the 1440px media-query. This is just streching the card way to much - Try using lesser height definitions like you do in the
div.main
element, you can get rid of that height. Also when creating buttons, don't use like aheight: 40px
it's better if you use padding like apadding: 15px
- Try using more semantic html and not so much divs, here an article about it.
There is always room for more improvements but for me this are the more pressing ones in your case
Hope this helps,
Cheers!
PS.: You should also look at the report and try to fix the errors it tells you
Marked as helpful - You should really get rid of the
- @grizhlieCodes@B1N4R1
Great job! I loved your solution, real cool!
Cheers!
P.S: I'm gonna use what u suggested for the filtering, I did it with a classical while loop I didn't remember about those two functions!
- @uiGuys@B1N4R1
Hi uiguy,
Great solution to the challenge! Both the layout and the calculator logic are great.
Here some little suggestions:
- I would get rid of the
max-width: 770px
on the 600px media-query the calculator looks too stretched to my eyes. - I would avoid letting the user type in multiple periods (......). This is causing some problems when making calculations. Like for example you can calculate 8 + 6...... which is giving some syntax error.
Btw, nice work with the theme toggle too.
Cheers!
- I would get rid of the
- @yasssuz@B1N4R1
Hi Karim,
Nice solution to the challenge!
If you take a look at your html the
data-filter
attribute of some of theli.job
elements have some commas, leading the JS to think the commas are also another language or tool? Idk that's my best guessCheers!
- @MSS023@B1N4R1
Hi Manan,
The solution looks good, here some improvements:
- The design approach you took is good but I would suggest using CSS grid for this one, this way you don't need to use that much divs.
- Also I would suggest using rems to define font-size instead of %
- The logic for the calculator works great just be carefull with the multiple periods (.....), you should only allow for one period to be inserted.
Rest of it looks nice, good work!
Cheers!