
_nehal๐
@NehalSahu8055All comments
- @Maikl-k@NehalSahu8055
Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- To
dynamically center the card
. Don't usemargins
- USING FLEXBOX
body{ display: flex; justify-content: center; align-items: center; min-height: 100vh; ... }
-
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one heading
-
<h1>Improve you frontend skills by building projects</h1>
-
Don't use multiple
<p>
for the single descritption use only one. -
Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding๐
- To
- @heyannli@NehalSahu8055
Hello Coder ๐.
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
- It would be better if you use source media for switching to screen sizes(mobile or desktop) for image.
<picture> <source media="(min-width:800px)" srcset="yourimage.jpg"> <img src="yourimage.jpg" alt="description"> </picture>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "Gabrielle Chanel Perfume bottle surrounded by leaves."
. -
Use semantic element for strike-through
<s>$169.99</s>
-
If you want to dive into
accessibility
for this project check this link
I hope you find this helpful.
Happy coding๐
- @rachidnaitlahaj@NehalSahu8055
Hello Coder ๐.
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- To
properly center the card
- USING FLEXBOX
body{ display: flex; justify-content: center; align-items: center; min-height: 100vh; ... }
- Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
- It would be better if you use source media for switching to screen sizes(mobile or desktop) for image.
<picture> <source media="(min-width:800px)" srcset="yourimage.jpg"> <img src="yourimage.jpg" alt="description"> </picture>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "Gabrielle Chanel Perfume bottle surrounded by leaves."
. -
Use semantic element for strike-through
<s>$169.99</s>
-
If you want to dive into
accessibility
for this project check this link
I hope you find this helpful.
Happy coding๐
Marked as helpful - To
- @Gean-Junio@NehalSahu8055
Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
-
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one heading
-
<h1>Improve you frontend skills by building projects</h1>
-
Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding๐
Marked as helpful -
- @beowulf1958What are you most proud of, and what would you do differently next time?
learning to use Sass variables
What challenges did you encounter, and how did you overcome them?I had a bit of trouble with centering the card at first; check on solutions to other challenges by other people and was able to finally get it centered
What specific areas of your project would you like help with?my h1 breaks the line differently than the design jpg
@NehalSahu8055Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
-
Use
min-height:100vh
instead ofheight:100vh
Todynamically center the card
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
.
I hope you find this helpful.
Happy coding๐
Marked as helpful -
- @JesnerW@NehalSahu8055
Hello Coder ๐.
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- It would be better if you use source media for switching to screen sizes(mobile or desktop) for image.
<picture> <source media="(min-width:800px)" srcset="yourimage.jpg"> <img src="yourimage.jpg" alt="description"> </picture>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "Gabrielle Chanel Perfume bottle surrounded by leaves."
. -
Use semantic element for strike-through
<s>$169.99</s>
-
Use
<button></button>
for button as it a semantic element -
If you want to dive into
accessibility
for this project check this link
I hope you find this helpful.
Happy coding๐
Marked as helpful - @SarahCooper-TC@NehalSahu8055
Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- Use
min-height:100vh
instead ofheight:100vh
Todynamically center the card
body{ display: flex; justify-content: center; align-items: center; min-height: 100vh; ... }
- Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding๐
Marked as helpful - Use
- @syfe-hub@NehalSahu8055
Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- To
dynamically center the card
usemin-height:100vh
instead ofheight:100vh
body{ display: flex; justify-content: center; align-items: center; min-height: 100vh; ... }
- Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding๐
Marked as helpful - To
- @Raiquen248@NehalSahu8055
Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- Don't use
margins
to center the card, Todynamically center the card
- USING FLEXBOX
body{ display: flex; justify-content: center; align-items: center; min-height: 100vh; ... }
- Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
- For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
.
I hope you find this helpful.
Happy coding๐
Marked as helpful - Don't use
- @YeniUvwo@NehalSahu8055
Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
-
Don't use
paddings or margins
for centering the card as it will notdynamically center
the card remove this and use either flex or grid for the same -
To
properly center the card
-
USING FLEXBOX on the parent element
body{ display: flex; justify-content: center; align-items: center; min-height: 100vh; ... }
-
You are
wrapping main and footer
inside adiv
its unnecessary to do this. -
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding๐
Marked as helpful -
- @Official-Nakul@NehalSahu8055
Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Regarding your image issue
- Since you are using your site with
vite
your images will not work unless you put yourqr-image
insidepublic folder
- Tip : You can generate a new screenshot after making the necessary changes
I hope you find this helpful.
Happy coding๐
- Since you are using your site with
- @tushargola1@NehalSahu8055
Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- To
dynamically center the card
- USING FLEXBOX
body{ display: flex; justify-content: center; align-items: center; min-height: 100vh; ... }
-
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one heading
-
<h1>Improve you frontend skills by building projects</h1>
-
Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding๐
- To
- @YoniiDev@NehalSahu8055
Hello Coder ๐.
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
-
Add
min-height:100vh
to your.seccion_results_summary_component
to dynamically center the card. -
Use
responsive units(rem, em, %)
from next project to increase responsiveness. Explore respective use cases on google. -
Use
max-width
instead ofwidth
to make your design responsive.
I hope you find this helpful.
Happy coding๐
Marked as helpful -
- @chalisamie@NehalSahu8055
Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
- Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding๐
-
- @joelbaah@NehalSahu8055
Hello Coder ๐
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- Don't use
position or margins
for centering the card as it will notdynamically center
the card remove this and use either flex or grid for the same
.qrcard { /* position: relative; */ /* top: 50%; */ /* left: 50%; */ /* transform: translate(-40%,40%); */ }
- To
properly center the card
- USING FLEXBOX
body{ display: flex; justify-content: center; align-items: center; min-height: 100vh; ... }
-
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one heading
-
<h1>Improve you frontend skills by building projects</h1>
-
Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding๐
Marked as helpful - Don't use
- @lspacka@NehalSahu8055
Hello Coder ๐.
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
-
Remove
margins
and addmin-height:100vh
to your.qr-container
to dynamically center the card. -
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one heading
-
<h1>Improve you frontend skills by building projects</h1>
-
Use
Semantics
for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding๐
Marked as helpful -
- @Kashyxp-patel@NehalSahu8055
Hello Coder ๐.
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- To
properly center the card
- USING FLEXBOX
body{ display: flex; justify-content: center; align-items: center; min-height: 100vh; ... }
- Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
- It would be better if you use source media for switching to screen sizes(mobile or desktop) for image.
<picture> <source media="(min-width:800px)" srcset="yourimage.jpg"> <img src="yourimage.jpg" alt="description"> </picture>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "Gabrielle Chanel Perfume bottle surrounded by leaves."
. -
Use semantic element for strike-through
<s>$169.99</s>
-
If you want to dive into
accessibility
for this project check this link
I hope you find this helpful.
Happy coding๐
- To
- @ledoux25@NehalSahu8055
Hello Coder ๐.
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- To
properly center the card
- USING FLEXBOX
body{ display: flex; justify-content: center; align-items: center; min-height: 100vh; ... }
- Use Semantics for the proper design of your code.
<body> <main>... main content goes here ...</main> <footer>... .attribution div goes here ... </footer> </body>
-
Use semantic element for strike-through
<s>$169.99</s>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "Gabrielle Chanel Perfume bottle surrounded by leaves."
. -
If you want to dive into
accessibility
for this project check this link
I hope you find this helpful.
Happy coding๐
Marked as helpful - To