Skip to content
OverviewSolutions
8
Comments
15
Okafor Raphael
@OkaforRaph

All comments

  • Okafor Raphael•240
    @OkaforRaph

    Hey @abdullah, congratulations on completing the coding challenge 🎉 👏.

    Here are some tips to better optimize your code:

    • Always add labels to your form elements

      <input type="email">

    • Also consider looking at some of your HTML issues..

    Hope this helps, Happy Coding 😊

  • Okafor Raphael•240
    @OkaforRaph

    Hey @ Mayank, Congratulations on completing the challenge 👏

    Here are some tips to help you code better:

    • Consider using h2-h6 elements to add identifying headings to all sections.
    • Always look at the accessibility and HTML errors you get after every challenge and correct them.

    Hope this helps, Happy Coding 😊

  • Okafor Raphael•240
    @OkaforRaph

    Hey @ Xiomara, congratulations on completing the challenge 👏 🎉. You did a great job 👍.

    Here is a tip for optimizing your code better: -Consider using h2-h6 elements to add identifying headings to all sections instead of "p".

    -Also take a look at some of the HTML issues you have 😉.

    Hope this helps, Happy Coding 😊

    Marked as helpful
  • Okafor Raphael•240
    @OkaforRaph

    Hey @ Satya, Congratulations on completing the challenge 🎉.

    Here are some tips to help you on your next project..

    • First, there are issues with accesibility and HTML issues from your code which should be looked at.

    • Secondly, the arrow on your hero section is not there (From the preview).

    • Also, your code is not linked properly (I think you linked the wrong GitHub repository) so I can see your code to correct you further.

    Hope this helps, Happy Coding 😊

    Marked as helpful
  • Okafor Raphael•240
    @OkaforRaph

    Hey Martinez, congratulations on completing the challenge! You did a great job 😉.. Yo also have a comprehensive knowledge of flexbox which is really nice.

    Let me give you some little tips and answer your question:

    1st .cards { margin-top: 2rem; display: grid; grid-template-columns: 1fr 1fr; max-width: 40rem; margin: 1rem;

    }

    2nd

    .card_two { grid-column: 1/-1; This will span it to fill the first column and push the other two down }

    If you have any further questions, you can ask, and i will answer Hope this helps! Happy coding 😁

    Marked as helpful
  • Okafor Raphael•240
    @OkaforRaph

    Congratulations on completing the project Emjhay 👍.. You did a nice job with your semantic HTML and the CSS 👌👏.

    If i can chip in anything at all, I would suggest you learn how to write a good Readme for your next challenge.

    Hope this helps.

  • Okafor Raphael•240
    @OkaforRaph

    Hey Moses, congratulations on completing the challenge! You did a great job 😉

    Let me give you some little tips for optimizing your code:

    • First, for semantic HTML, the section tag is expected to wrap the div and not the other way round.

    • Always make use of relative unit of measurement like "rem" instead of "px".

    Hope this help! Happy coding 😁

  • Okafor Raphael•240
    @OkaforRaph

    Hey Shehab, congratulations on completing the challenge! You did a great job 😉

    Just a tip for optimizing your code:

    • Always make use of relative units of measurement like "rem" instead of px.

    Hope this help! Happy coding 😁

  • Okafor Raphael•240
    @OkaforRaph

    Hey Brian, congratulations on completing the challenge! You did a great job 😉. Nice use of bootstrap by the way.

    Let me give you some little tips for optimizing your code:

    a) to make it look as close to the design as possible add "border-radius: .5rem and overflow: hidden" to container class.

    b) instead of using px use relative units of measurement like rem .

    Hope this help! Happy coding 😁

  • Okafor Raphael•240
    @OkaforRaph

    Congrats Rodrigues on completing the challenge, you did a very nice job especially with the semantic HTML 👏.. If I can chip in anything at all, I will advice you to take time to write the README before posting your next project.

    Overall, you did a great job 👍

    Marked as helpful
  • Okafor Raphael•240
    @OkaforRaph

    Very nice job implementing the design, although the normal button state was not implemented according to the design. Nice work overall though, Keep it up Rudro.

    Marked as helpful
  • Okafor Raphael•240
    @OkaforRaph

    Hey Jhonatan, congratulations on completing the challenge! You did a great job 😉

    Let me give you some little tips for optimizing your code:

    1. Tip of graphic design: with font-family:" Big Shoulders Display ", cursive the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with a font-family:" Big Shoulders Display ", sans-serif much more similar to the primary font.

    2. add main tag and wrap the card for improve the Accessibility

    3. also, you did not add a hover state to your buttons

    4. add transition on the element with hover effect (the buttons)

    5. You used a mixture of px and em units. Instead of using px use relative units of measurement like rem -> read here

    Hope this help! Happy coding 😁

    Marked as helpful
  • Okafor Raphael•240
    @OkaforRaph

    Hey Samuel, congratulations on completing the challenge! You did a great job 😉

    You did a lot to optimize your code, which is really nice, I only hope that next time, you add an "alt text" to your images for easy accessibility.

    Hope this help! Happy coding 😁

  • Okafor Raphael•240
    @OkaforRaph

    Hey @ Minwoo Soh, congratulations on completing the challenge... U did a very good job with the component. As for your question, ''rem" is a more suitable unit to use for width and height than em

  • Okafor Raphael•240
    @OkaforRaph

    You did a beautiful job, congratulations on completing the challenge. The only problem with the project is that you did not size your images accordingly. still give yourself a pat at the back... You did a good job overall.