Skip to content
OverviewSolutions
17
Comments
314
Adarsh Pratap
@adarshcodes

All comments

  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @AryaDixit, first of all, welcome to this amazing community! You did nice work on this solution👏.

    Few things I've liked and noticed about your solution:

    Design aspect: Your design is very similar to the given design file. Only a couple of things I've noticed that you can change the font colors for the paragraphs.

    Responsive aspect: It's responsive and will work on most of the screens. Good work.

    Functionality aspect: It's working fine.

    Code: While everyone has their own style and approach to code few things make the code clear and clean and you really did amazing work on that.

    Accessibility and HTML Issue: You can check the report and you'll notice very small issues causing those issues, you can always fix that and regenerate the report here.

    You did amazing work👍. Keep practicing. Happy coding :)

  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @JFREUN, you did nice work on this challenge. Your design is very close to the original one. Keep up the good work👏

  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @seanyoung247, first of all, let me tell you I've done this project and I know it's really hard. Second thing is you not only nailed it but also took it to another level🤯. I myself am the person who tries to add many extra things and animations in my solution but this solution is really very amazing and I really loved it.😍

    The subtle animation and the addition of extras without messing with the actual design. Amazing👏👏👏.

    I can't give you the review on your react code as I'm a newbie in react. Just fascinated with the solution.

    Happy Coding :)

  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @carlin-mitchell, first of all, welcome to this amazing community, and you did really nice work on your first challenge👏.

    And yes there's a huge room to learn the best practices which you'll learn eventually by practicing. Just a suggestion from my side is to keep working on the project consistently and take a look at others' code but don't carry it away by the approach of others. Every one of us has our own style of coding the things you should learn is the best practice and what you like in others' code. Create your own style of code while keeping the best practices in mind.

    For your question: leave the background image to the top only, it'll mess with the design if you centered it.

    Congratulations on submitting your first solution🎉🎉🎉. It's a long and beautiful way to go. Keep learning and practicing. Happy Coding :)

    P.S: take a look at your accessibility and HTML issues and try to fix them. And yeah, Every mistake is an opportunity to learn something new, so never miss it.👍

    Marked as helpful
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @Jrlinkin, you did nice work on this solution👏.

    Few things I've liked and noticed about your solution:

    • Design aspect: Your design is very similar to the given design file. Only a couple of things I've noticed missing are the icons on the bills and the number of person input fields.

    • Responsive aspect: It's responsive and will work on most of the screens. Good work.

    • Functionality aspect: It's working fine.

    • Code: While everyone has their own style and approach to code few things make the code clear and clean and you really did amazing work on that. I like you added the comment wherever needed and your code looks really clean.

    • Accessibility and HTML Issue: You can check the report and you'll notice very small issues causing those issues.

    You did great work👍. Keep practicing. Happy coding :)

    Marked as helpful
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @Nafsuki, your solution looks really nice.

    • Design looks similar to the original one, make the width of the container 100%, it will look more similar.
    • Responsiveness is working fine. Keep it up. Happy Coding😀
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @FitItGuy, you did good work on this solution. I think most of the things @SzymonRojek has already covered above so please go with the suggestion. Keep it up. Happy coding😀

  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @RayaneGomes97, Your solution looks really nice to me👏

    • design is similar to the original one.
    • Responsiveness is also working smoothly.
    • one small thing I would suggest you, add the attribution to the footer.
    • Also try to solve HTML and Accessibility issues. Keep it up. Happy Coding😀
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @thewebguyy, I think you submitted this solution in the wrong challenge section. Please check it.

  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @Jose-Angel-Rey, You did a nice job on this challenge. Great👏.

    • I like the beating animation on the image.
    • HTML structure is fine and the code looks clean.
    • Responsiveness is also working great. Keep it up👍. Happy Coding😀
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @biancahpp, you did amazing work on this challenge👏.

    • Your design is pretty similar to the originally provided design.
    • I like the small things you added, like the check icon
    • Dark mode is working great.
    • And every functionality is working properly.
    • Responsiveness is also working nicely.
    • Try to solve HTML and Accessibility issues. Keep it up👍. Happy Coding😀
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @wenadev,

    • your solution looks really cool and similar to the original design.
    • the dark mode is working properly.
    • Responsiveness is working nicely as well. Keep it up. Happy coding😀
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @edsonJordan, Welcome to this amazing community, and also congratulations on submitting your first solution over here.

    • Your solution looks nice.
    • For those background images use CSS background-img property. Learn more about here. I hope it will help you. Keep it up. Happy Coding😀
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @Kucabara21, You did amazing work on this solution👏.

    • design is a pixel perfect to the originally provided design.
    • pop-up is working fine.
    • responsiveness is also working nicely. Keep it up. Happy Coding😀 P.S: I don't think that any filter is applied to the image(Correct me if I'm unable to understand your question😅).
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @danielhopler, Welcome to this amazing community, and also congratulations on submitting your first project. I would also suggest you to take a look at @grace-snow 's solution. She had done great work on it. Keep it up. Happy Coding😀.

  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @rcrespoc, You did nice work on this challenge.👏

    • Your design is fine, you can make it more similar to the original design by making the timer card a bit big and also start the clock at 8 days.
    • Responsiveness is working fine.
    • Try to solve accessibility and HTML issues. Keep it up. Happy Coding😀
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @stephenduenas, you did great work on this challenge👏

    • Design is very similar to the original design and works perfectly.
    • I saw a few solutions where it doesn't get the IP automatically. It works in your solution.
    • Responsiveness is working fine. Keep it up. Happy Coding😀
  • Adarsh Pratap•5,515
    @adarshcodes

    Hi @andrikp3, welcome to this amazing community. You did nice work on this challenge. You can change the color of the footer. The color is in the style-guide file. Keep it up. Happy Coding😀