vishal wankhade• 495
@Vishal-wankhade
Submitted
second challenge of my here. feel free to give your valuable feedback and suggestions
darshii
@darshii98
All comments
- darshii• 525
@darshii98
Posted
No reponsiveness in your design mate, maybe either work with flexbox or at every suitable width of screen, decrease the width of your container, also set your entire container's overflow to hidden.
Marked as helpful
0 - Tyson W• 305
@Tyson-Wellings
Submitted
Let me know if any bugs occur! Would be grateful to received feedback on the JS mainly as I am unfamiliar with best practices.
darshii• 525@darshii98
Posted
Your amount increases but backers don't increase. So maybe try to change that!!. Also adding some transitions might help smooth things out in case of buttons and bookmark. Awesome Job bdw!!
Marked as helpful
0 - 7milkyways• 100
@iamdestinychild
Submitted
this project was really fun i tell you, but it would have been better if we where not given the pageview to target a price it would had been better if we just had to write the function to solve for it, thanks for this project . LOVE 7milkyways.
darshii• 525@darshii98
Posted
The slider component is not smooth. 8, 12, 16 are showing in the beginning and 36 at the end. Maybe you should think about implementing a uniform step size. Also below 400px screen width, the toggle switch appears to be very small, and the toggle effect isn't effective, try to maybe put a min-width on the toggle. Everything else looks great. Happy Coding!
Marked as helpful
0 - Deepak Kumar Asnani• 310
@deepak539
Submitted
Any feedbacks will be appreciated.
darshii• 525@darshii98
Posted
Awesome job man. One small nitpick, when on the active tab if I check some items as completed, they still remain there and do not immediately get transferred to completed. I have to click completed and then on active again, to see that they are not there. If that could somehow change, then it will be a great app.
Marked as helpful
0 - Asfand Yar• 20
@asfand687
Submitted
- I would like to know about what is the best practice for making the navbar for the mobile screens, how can we add some transition effects on them when they appear on the screen.
- What is the best practice for using the pictures? Should we use them as background or we should just render them using img tags?
- How have you used the svgs? with the img tags or have you used the inline-svgs? Whats the best practice to use the svgs in our projects?
darshii• 525@darshii98
Posted
-
Set visibility to hidden below a certain screen length, preferably at tablet size(768), then you can make the container of the nav-links flex, with flex direction column, make position absolute, and give some padding to the links, to make it look like a list. To add transition effect either you can use transform translate or you can make the height of the container zero and when menu burger icon is clicked, set the height to unset or original and use transition to animate it.
-
Sometimes its better to use directly images, but in case of the design and photography section of your site, you can use image as background.
-
Svgs I have used in the sass itself and used filter property to change the color. (for icons I have used ion-icons, but you can also use the provided ones and change their color using filter when hovering)
Marked as helpful
0 - Saif Narpali• 590
@SaifN97
Submitted
Any tips for color change when hovering on svgs? Thanks in advance :)
darshii• 525@darshii98
Posted
Use the filter property to change color of images. You can find it in mdn. Something like " filter: brightness(0) saturate(100%) invert(37%) sepia(13%) saturate(2008%) hue-rotate(116deg) brightness(93%) contrast(93%);"
Marked as helpful
1 - Rohit• 330
@Rohitgour03
Submitted
hello, How to fix the background images position ??? Please give your valuable feedback and suggestion.
darshii• 525@darshii98
Posted
GIve the container a background url() and set it's position in terms of vh vw...something like " background-position: right 51vw bottom 40vh, left 49vw top 49vh", .
Marked as helpful
0 - Writam Biswas• 105
@bwritam
Submitted
how can i get better result if there any?
darshii• 525@darshii98
Posted
Below 760px screen width, you can set the background of the card to 'repeat'. Because right now it just shows the background image on one side and white space on other.
Marked as helpful
0 - Jacob• 130
@Vastagon
Submitted
I couldn't figure out how to add any padding at the bottom and used a p tag to create a bit of space. How do I not have to do that? I know that that was a bad solution.
darshii• 525@darshii98
Posted
Make your single card component's position relative and your button's position as absolute, then give a distance from bottom to your button, it will work. You can refer my solution if you want. Also change your entire card component's flex direction to column if you want to make it responsive in mobile view.
Marked as helpful
1 - Anna• 545
@NitaLewska
Submitted
Hi everybody =) It was my first challenge with JS, and I hope I've managed good enough
darshii• 525@darshii98
Posted
You could set the input values to "", after submit button is clicked (when no errors), so that it would seem as if form is submitted. Bdw, nice job !! ;)
Marked as helpful
1
