@Faraz-mobin17
Latest comments
- P@emawid
Hi Faraz,
Great work with the password generator! You have solved the core functionality very well with a good UI. To improve further I suggest to focus on the design and layout. For example, typography and aligning the element for "Character Length" with the character length number output. You could also try and implement the strength bar features to get it more closely the the intended design.
- P@thanasisproP@emawid
Hello Thanasis,
Nice work with the tip calculator app! I think you have captured the look and feel very close to the design files. If you were to improve the app I would suggest adding an error message for the bill input field as well and maybe setting the defualt number of people to 1 since its optional.
- @sthitaprajna-mishraP@emawid
Congrats on completing the time tracker challenge. Great work! A couple of points to conisder for the next challenge:
- The responsiveness looks great on desktop and mobile but looks a bit sqished on tablet. My advice is to to either increase the size of each activity card or dynamically reduce the font size, whatever looks best for the user.
- The main content jumps when decreasing the screen size from desktop to tablet. I suggest you keep the same position for the main content for all acreen sizes. Either center or top-center. Good luck on your next challenge!
- P@mirkozlatunicWhat are you most proud of, and what would you do differently next time?
I applied the JavaScript fundamentals to React components and hover styles so that they are used when clicking the buttons. I would refactor the code even more into reusable components.
What challenges did you encounter, and how did you overcome them?I had challenges applying the proper function to the form. I needed to go back to the code multiple times to get the results that I have now.
What specific areas of your project would you like help with?I'd like feedback on the refactoring part and how others would approach the React functionality with form validations.
P@emawidGreat job with the newsletter sign-up challenge. What an accomplishment! I do not have any experience with React so I can only comment on the overall look and feel. The solution is close to pixel perfect compared to the design specification. It looks good on different screen sizes.
- @ExtendoGHWhat are you most proud of, and what would you do differently next time?
This is my first project using JavaScript, so I'm really proud that I was finally able to add interactivity to the website. Next time, I’ll definitely have a better understanding of how to manage CSS classes like
What challenges did you encounter, and how did you overcome them?.hiddento control the visibility of elements more effectively.The biggest challenge I faced was styling the popup that needed to overlay certain parts of the project. Fortunately, with the help of ChatGPT, I managed to get it working and added a smooth show/hide animation, which really improved the overall user experience.
What specific areas of your project would you like help with?I’d really appreciate any feedback, especially regarding the JavaScript code, since this was my first time writing it.
P@emawidGreat job on the challenge. The solution is almost pixel perfect. I can only spot a minor deviation on the mobile toaster which does not seem to have rounded edges. Layout looks good on all screen sizes, even with the toaster. Solution include semantic HTML and is well structured. Nice implementation of the JavaScript and use of classList and toggle().
- P@drewleeWhat are you most proud of, and what would you do differently next time?
I'm pleased I was able to get this complex layout fully responsive and smoothly transitioning between the three major screen sizes. I was also able to leverage both Flexbox and Grid for laying out the various components on the page. Next time, I would probably come up with a full-page systematic grid system to handle element positioning.
What challenges did you encounter, and how did you overcome them?The visual design features numerous inconsistencies in spacing and text wrap handling, which is somewhat ignorant of how CSS styling actually works. We should try to avoid having to hardcode text block widths and let text flow naturally to fit the screen width. While I understand adding complexity to make the exercise challenging, the visual treatment is not very practical in a real-world scenario.
What specific areas of your project would you like help with?Ensuring adherence to best practices and modern coding conventions.
P@emawidHi Andrew, Nice work with the landing page! Solution is almost pixel perfect. Good use of semantic html elements. For image elements, always provide a default width and height attribute as the browser will reserve space for it. If not provided overall page layout can jump around after page load. Accessibility could be further improved with ARIA labels. Solution looks good on different screen sizes.
