Skip to content
OverviewSolutions
16
Comments
23

karenefereyan

@karenefereyanNigeria375 points

Learning frontend development the right way. I'm always up to chat. Feel free to ask for feedback. If I don't know, we can search for the answer together.

I’m currently learning...

HTML CSS JAVASCRIPT

Latest solutions

View more solutions

Latest comments

  • karenefereyan•375
    @karenefereyan

    HI Sarah. I love the simplicity of your approach. Beautiful. Here's something I just wanted to point out.

    1. It is always a good idea to stick to separation of concerns in web development. That would mean to let html handle everything structure, while css handles everything styling. It might be negligible for this particular projects but in bigger projects, letting each pillar(HTML || CSS || JS) handle their own concerns will help with organization.

    Keep going!!!!

    Marked as helpful
  • karenefereyan•375
    @karenefereyan

    This detailed feedback is so helpful. Thanks Agata. I always felt comfortable designing for mobile screens too.

    I think I'll have to take another shot at this going step by step. I've watched that video from webdev simplified when I started this challenge but I'll have to do that again.

    Could you please explain what you mean by you couldn't toggle using your keyboard? I'm still trying to make my solutions as accessible as possible

  • karenefereyan•375
    @karenefereyan

    Hey Anisha this is pretty. Its responsive as well. You might wanna increase the width of the individual cards on smaller screens or reduce the left padding. Nice work once more. Keep coding

  • karenefereyan•375
    @karenefereyan

    Hey, toms, beautiful work. First, you might wanna consider fixing the HTML validation issues. You shouldn't have a SRC attribute in a button. As regards changing the hamburger to close, you could simply just use the transform property. But I think they provide a different close image, so maybe at the point where you're checking whether the mobile menu is shown or not, you could toggle the close button which you gave a close-menu class to. I'm still a beginner at react so my answer is subject to corrections.

    Overall, superb work. Keep coding😶😶😶😶

  • karenefereyan•375
    @karenefereyan

    Hey soqk, lovely work here. On mobile devices, the header could use a little more spacing to distinguish it from the nav. I'd say the same for the cards and footer too. Adequate spacing enhances legibility. Great work. Keep coding. Cheers!!! 😉😉😉😉

  • karenefereyan•375
    @karenefereyan

    Hey. Nice work here. You could make the border radius a little more rounded. A value of 30PX usually does the trick. Also the paddings before and after the Learn more links seem a bit too much

View more comments