Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Log in with GitHub
OverviewSolutions12Comments152

All comments

  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Good job with the solution! Looks nice, I just have a couple of things I think you can improve:

    • At around 930px screen width, the form looks very thin, so I think you should increase the width a bit.
    • Also it would be good if you add transition on hover state.

    Keep Developing👍

    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution looks pretty good! I just have a couple of suggestions:

    • Firstly, there is a vertical scroll bar in your solution and I don't think it should be there.
    • And I suggest you to remove the default outline on focus state from buttons and links.

    Apart from these you solution looks nice, keep it up👍

    Marked as helpful

    1
  • CoderPr0• 645

    @CoderPr0

    Submitted

    This is my next work. I struggled a bit with the Javascript bit, but I think I did a decent job. As always any tips or feedback would be appreciated.

    Time-tracking-dashboard

    1

    Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Good job on completing the challenge! I just have one suggestion for you:

    • Try to use relative units like em and rem more instead of px as it is a good practice and helps in responsive design as well!

    Keep Developing👍

    Marked as helpful

    1
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Great job with the solution! Looks great, but.. I just have one suggestion for you:

    • Try to use relative units like em and rem more instead of px.

    Keep Developing👍

    Marked as helpful

    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution is really good! But.. I found a few suggestions:

    • Try to use semantic html tags like main, section, header, etc. more as it is a good practice and good for SEO.
    • Also, I think you should remove the margin-top: 10rem; from 886px media-query as because of it there is a vertical scrollbar.

    Keep it Up👍

    Marked as helpful

    0
  • Jonathan• 295

    @Nathan-Front

    Submitted

    Updated version: Any suggestions on the javascript of the feature area of this challenge? Not really sure if my javascript on this is good or not?

    Book mark landing page

    1

    Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution looks good, but.. I have a few suggestions:

    • In the features section, when I try to click on the other feature, the details below won't change. So try to add it.
    • Also it would be great if you add some transition to hover state.

    Marked as helpful

    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution looks good, but.. I have found a couple of issues:

    • You have not add any form validations, so add it.
    • And also add some hover effect with transition to the buttons and links

    Keep it up👍

    Marked as helpful

    1
  • Shanib Ibrahim• 110

    @shanib-ibrahim

    Submitted

    I have completed another challenge using js for the first time, I appreciate your feedback to continue improving my code to keep growing

    HTML,SASS AND JS

    1

    Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution looks great! Maybe just add some transition to hover effect.

    Keep it up👍

    Marked as helpful

    0
  • MHIEN• 230

    @MinHien-git

    Submitted

    i want to center the card without using position absolute and translate(-50%,-50%)

    css and HTML

    1

    Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    • To center the card you can use display: flex; and place-items: center; to the parent.

    Hope it helps🤗

    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Good job on completing the challenge! But.. I have a few suggestions:

    • On the buttons, at normal state, there is no border, but when hovered there is a border. So, when I hover it the content just pops up because of the border. To fix that maybe add a transparent border at normal state.
    • Also it would be good if you add some transition on hover state.
    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution is really Good! I just have one suggestion for you:

    • Add some transition to hover effects, as it will increase the experience.

    Keep it Up👍

    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution is really good! Looks great, but.. I just found one issue:

    • Below screen width of 375px the cards all become aligned like on bigger screen instead of like it should be on small screens.

    Apart from these, it looks really good, Keep it Up👍

    Marked as helpful

    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Great job with the solution! Looks really good, but.. I have a couple of suggestions:

    • First, I think you should change the value in media query to 900px instead of 768px as around 850px screen width, there seems to be an horizontal scrollbar.
    • And a minor thing, in your solution there is lot of empty white space at the bottom of the cards.

    Apart from these, it is really good, Keep it up👍

    Marked as helpful

    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution is really good! But.. I found a few suggestions:

    • Try to use semantic html tags like main, section, header, etc. more as it is a good practice and good for SEO.
    • Also try to use relative units like em and rem more instead of px.
    • And a minor thing, add some transition to hover state`.

    Keep it up👍

    Marked as helpful

    1
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution is really good! But.. I found a few suggestions:

    • Try to semantic html more.
    • Also try to use relative units like em and rem more instead of px.

    Keep it up👍

    Marked as helpful

    1
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Great job with solution! Looks really good, but.. I have a few issues:

    • At around and below 980px there is a vertical scrollbar and I don't think it is supposed to be there.
    • Also try to use relative units like em and rem more instead of px.

    Apart from these, your solution is nice, keep it up👍

    0
  • Carl Jones• 200

    @jones9411

    Submitted

    Had a bit of trouble getting the text to where I wanted them, any advice on how to do it better?

    HTML and CSS

    1

    Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Good job with the solution! I just found a couple of issues:

    • Use sematic html tags like main, section, header, etc. more as it is a good practice and good for SEO.
    • You have not added any hover states to any links and buttons, so add it with some transition.

    Marked as helpful

    1
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution is nice! But.. I found a couple of issues:

    • At default state, the buttons don't have a border, and when in hover state you are adding a border so the content above it moves up by a bit, so add a transparent border to normal state.
    • Also you have not add any hover states to buttons, so add it with some transition.

    Keep it Up👍

    Marked as helpful

    1
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Great job with the solution! I just have I issue that you can fix:

    • At around 1000px, because of the image grid section, there is horizontal scrollbar, so try changing the values in media query to fix it.

    Apart from it, site looks nice, keep it up👍

    Marked as helpful

    1
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Great job with the solution! Looks really good, but.. I found a couple of things you can improve:

    • You have not add any hover states to the button, so add it with some transition.
    • Also a minor thing, add some border-radius to the card.

    Keep it Up👍

    1
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    I found a few issues with the site:

    • Try to use relative units like em and rem more rather than of px.

    Apart from these your solution is really nice, keep it up👍

    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    I found a few issues with the site:

    • There is a vertical scrollbar, because of the footer maybe try adding a height of 100vh.
    • Also use relative units like em and rem instead of px.

    Apart from these your solution is really nice, keep it up👍

    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Good job on completing the challenge! But.. I found a few issues:

    • Even on big screen, the navigation bar is like it should be on mobile(the hamburger menu). Also the menu isn't working on click!
    • You have not add any hover states to any links and buttons, so add it with some transition.
    • Also change the value of media query as around 900px the content looks squeezed and even a horizontal scrollbar comes up because of the image gallery section.

    Marked as helpful

    0
  • Dharmik_487• 1,740

    @Dharmik48

    Posted

    Hey👋,

    Your solution looks really Good! Though I just have a few suggestions:

    • You have added a class of main to the section, and I think instead of that you can directly use main tag.
    • Also try to use relative units like em and rem more than px.

    Keep it up👍

    Marked as helpful

    0