Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P

    @metinahmeterkeles

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm happy to code another design. I learned many different new things on this journey. I am happy that I can code the design for mobile and desktop screens.

    What challenges did you encounter, and how did you overcome them?

    I thought a lot about whether I should start coding from mobile design or desktop design. I think starting from mobile design is a much better solution.

    What specific areas of your project would you like help with?

    Responsive layout

    Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 Congratulations on completing the challenge! 🎉

    I recommend you remove those heights that you placed on the .container element and also that overflow: hidden since on smaller screens or horizontally placed devices it can cause overflows and non-visible content.

    I think you forgot to remove the text from the alt attribute in the image, also remember to add it if the image has a semantic meaning or is not for decoration. And if you add it, remember to use descriptive text.

    To prevent text wrap in the span element inside the button you can use something like this: max-width: max-content instead of max-width: 85px or just remove that max-width!

    I hope this helps! 😁

    Marked as helpful

    0
  • Gabriel 10

    @Ghm84

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm happy with the result since it's the first repository I've made.

    What challenges did you encounter, and how did you overcome them?

    After I've finished the image didn´t show up, so I had to make some changes.

    What specific areas of your project would you like help with?

    The responsive design.

    Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 Congratulations on completing the challenge! 🎉

    Remember not to use the alt attribute when the image has no semantic meaning or is only for decoration. And when you use it, you should write a more descriptive text.

    And if you decide not to use an alt attribute, remember to remove the image from the accessibility tree, the aria-hidden attribute will help you with that.

    Do not use the br tag to break texts, as it is considered a bad practice and can lead to accessibility problems, read more here 👉 br.

    I don't recommend using a fixed width in elements like the body, unless you want to make some kind of website where all the content has a few spaces on the sides, but for something like that it's better to use padding.

    I recommend that you use min-height instead of height as that will allow your content to grow if necessary.

    I hope this helps! 😁

    Marked as helpful

    0
  • @aanthey

    Submitted

    What are you most proud of, and what would you do differently next time?

    Im proud of completing this project by myself and being able to use documentation to figure out some issues. Next time I'd like to be able to complete a responsive design and learn best practices to make my code more efficient and concise.

    What challenges did you encounter, and how did you overcome them?

    The challenges I encountered were making the actual card itself and figuring out the positioning of the image inside the card. The Card - I tried to figure out using my own knowledge from the top of my head and when I couldnt i referred to the documentation from w3schools and it worked. Positioning the image - the main issue I had was trying to center the image inside of the card, I eventually found a decent work around when I played around with the padding but it didnt come out exactly how I wanted it to.

    What specific areas of your project would you like help with?

    I'd like help knowing best practices for my code and how to make it more clear and concise, so any tips would be appreciated!

    Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 Congratulations on completing the challenge! 🎉

    Remember to leave the alt attribute empty if the image doesn't have a semantic meaning or is just for decoration, and when using it you should use more descriptive text. Since the alt attribute is commonly used by screen readers to speak the alt of the image.

    Don't skip the headings, each page must first have an h1 element and then the others!

    Don't use units like vh to specify sizes on elements unless it's something like a background that you want to take up the entire height of the screen, in the img element you're using height: 38vh which on different screen sizes can make the image look bad.

    I also recommend reading a bit about the object-fit property as it will help you make the images look better. In this case, the cover value of the object-fit property will make the image look better.

    Hope this helps! 😁

    1
  • P

    @zlatan-cic

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm most proud of mastering CSS Grid and Flexbox to create responsive layouts, and next time, I would incorporate more semantic HTML elements to enhance accessibility and SEO.

    What challenges did you encounter, and how did you overcome them?

    While this project was relatively straightforward, I encountered some initial challenges with CSS Grid alignment, which I overcame by experimenting with different grid properties and reviewing documentation to better understand their effects.

    What specific areas of your project would you like help with?

    I would appreciate detailed feedback on optimizing the use of semantic HTML elements within my project to improve both accessibility and SEO, as well as any insights on enhancing the responsiveness of my CSS Grid and Flexbox layouts for various device screens.

    Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 Congratulations on completing the challenge! 🎉

    Remember not to use the alt attribute if the image is for decoration or doesn't have a semantic meaning, as people who use screen readers don't want to hear 'avatar' or 'illustration article'.

    Your challenge has no headings, remember that there must be at least one heading, you can use the a element inside a h1 element!

    I hope this helps! 😁

    1
  • Peter Wahu 110

    @Pe-te-r

    Submitted

    What challenges did you encounter, and how did you overcome them?

    Making the background image to occupy the whole of x axis on screen past 1500px. I had to remove the background image on big screen and leave it for small screens to show it.

    What specific areas of your project would you like help with?

    How do i make a background image to strecth on the x axis. The image provided on this project could not span on the x axis to occupy whole width when screen is past 1500px.

    Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 Congratulations on completing the challenge! 🎉

    To make the image take up the entire width of the screen regardless of the width of the device you can use: background-size: 100% or background-size: 100vwinstead of background-size: auto

    But I have to say that the 100% will only work if the element occupies the entire width of the screen, in this case the body occupies the entire width so no problem!

    It may be that on small screens the height of the image is very small, but to solve that I recommend you to do that background using a positioned element and not background-image property.

    I hope this helps! 😁

    0
  • @DakkarAlezzy

    Submitted

    What are you most proud of, and what would you do differently next time?

    1. I like the way i centered the card

    2. I dont know ,id be happy for anny advice

    What challenges did you encounter, and how did you overcome them?

    I couldnt post my live site, because the files were in 2 directiries. I still need to figure how to move around the files in git. My solution was just to create a new repository and copy the files.

    What specific areas of your project would you like help with?

    Just an advice or two for now . tnx

    Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 Congratulations on completing the challenge! 🎉

    The challenge doesn't appear on the live site because you have the wrong URL:

    You're using this 👉 URL which leads to an empty folder.

    You must use the folder where you have the challenge 👉 URL

    Now the challenge:

    Remember to specify a more descriptive alt attribute, or leave it empty if the image doesn't have a semantic meaning or is just for decoration.

    Don't skip the headings, you should use a h1 before a h2.

    I hope this helps! 😁

    Marked as helpful

    1
  • Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 congratulations on completing the challenge! 🎉

    Remember that you should not skip headings, you should use a h1 before using a h2, for example you could use a h1 in the text of .container__title.

    In the .container__message text you can use a p element, remember not to use the div element for everything!

    I recommend that you read about the 👉 vertical-align property since it will help you a lot to style elements like when they are not block elements.

    If the element is an icon, has no semantic meaning or is just for decoration you can leave the alt attribute empty.

    Adds the aria-hidden attribute to icons. To prevent them from being displayed in the accessibility tree.

    I hope this helps! 😁

    Marked as helpful

    0
  • P
    Neelxxx 50

    @Neelxxx

    Submitted

    What are you most proud of, and what would you do differently next time?

    understanding of css

    What challenges did you encounter, and how did you overcome them?

    centering elements , google to the rescue :P

    What specific areas of your project would you like help with?

    more on styling

    Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 congratulations on completing the challenge! 🎉

    When the size of the margin on each side is the same you can specify it only once margin: 20px and not margin: 20px 20px 20px 20px

    When the font you are going to use is the same you can use font-family on a parent element... like the body or the .outer-container. And this way you avoid adding it all the time to the elements with text.

    I hope this helps! 😁

    Marked as helpful

    0
  • Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 congratulations on completing the challenge! 🎉

    Do not add an alt attribute on images for decoration or on images that have no semantic meaning.

    Also remember to add the aria-hidden attribute on the icons. 👉 aria-hidden.

    I also recommend that you read about the 👉 event delegation, so that you avoid adding the same event to each accordionBtn.

    I hope this helps! 😁

    0
  • @Paulkendrick2126

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm proud of the fact that I was able to finish the project within the stipulated time I planned for.

    Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    Remember to specify a more descriptive alt attribute, since it is used by screen readers.

    Do not skip the headings, first you must use h1 not h2.

    Do not use the br tag, as it is considered bad practice, and on some screens it makes the text look bad.

    To avoid applying the font-family all the time, you can directly add it to its parent element, such as the body, and many of its child elements will inherit that style.

    I hope this helps! 😁

    Marked as helpful

    1
  • Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 congratulations on completing the challenge! 🎉

    Remember to add an alt attribute even if it is empty.

    To vertically align the image so that its container does not have extra space you can use vertical-align: middle property. If you want to read more about it here is the link 👉 vertical-align.

    Although by adding display: block to the image you will be doing the same thing I said above.

    Don't skip the headings, you should use h1 first, then the others.

    I have nothing more to add, you did amazing!

    I hope this helps! 😁

    Marked as helpful

    0
  • @Codelearner123456

    Submitted

    What are you most proud of, and what would you do differently next time?

    Getting it to work and not wasting time doing it.

    What challenges did you encounter, and how did you overcome them?

    Getting the image to load. I used a solution to help me.

    What specific areas of your project would you like help with?

    Css.

    Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 congratulations on completing the challenge! 🎉

    The image does not load because you are trying to access it in a non-existent folder! assets

    src="./assets/image-qr-code.png"

    should be:

    src="./images/image-qr-code.png"

    The way you use the br tag is incorrect and is considered bad practice, better use max-width or some other property to make the text take up less space.

    Use flexbox to center the .table element, you must set the properties to its parent element, in this case the body.

    I also recommend removing the default margin: 8px from the body element.

    I hope this helps! 😁

    Marked as helpful

    0
  • @Covenant-0

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am proud I finally completed this challenge completing this challenge. It took me a number of days.

    What challenges did you encounter, and how did you overcome them?

    The only challenge i faced was how to display different images on different screen sizes. I made a lot of research and i was finally able to do it. I learnt new things. The snippet below is an example of what i learnt. (```

                ```)
    

    What specific areas of your project would you like help with?

    I need help with importing fonts from the google fonts website. I made a lot of research and tried a lot of things but the font did not reflect in the code. If there's anyway i can go about this or any alternative, kindly let me know in the comments below. Thanks

    Product Preview Page

    #accessibility

    2

    Grego 1,050

    @Grego14

    Posted

    👋 Hello! 🎉 congratulations on completing the challenge! 🎉

    I recommend that you add the min-height: 100vh property to the body element so that it is centered correctly, but for that to work you must remove the margin-top: 128.75px that you added to the .container element.

    I recommend using min-height instead of height in the .container element as it is causing overflows, the min-height property will make sure that the element has a minimum height but that it also can grow.

    It is not necessary to add two source elements inside the picture element.

    <picture>
      <source media="(max-width: 799px)" srcset="image-product-mobile.jpg">
      <img src="image-product-desktop.jpg" class="image" alt="image of product">
    </picture>
    

    Since the image that is in the src of the img element will always be displayed until the screen width is 799px.

    Try adding a more descriptive alt attribute.

    To make the image take up the entire width of its parent, use min-height: 100%

    Try adding more descriptive classes something like this: image-container or product-info and not container1 container-2

    I don't see the Google fonts since my blocker prevents them from downloading, but in another comment I saw that someone already told you how to solve it.

    I hope this helps! 😁

    0
  • P
    KL 220

    @TorHamm

    Submitted

    What are you most proud of, and what would you do differently next time?

    Use normal method just reviewing my CSS knowledge

    What challenges did you encounter, and how did you overcome them?

    Sometime i can't remember something. I just search for it.

    What specific areas of your project would you like help with?

    I think i did well on this but if anyone see anywhere i can improve please tell me, thanks.

    Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    Leave the alt attribute empty if the image has no semantic meaning or is for decoration.

    I recommend you read about the 👉 vertical-align property since it can help you make the image occupy the height of its parent element, although just adding display: block would also be doing the same thing.

    There is a shorthand for the align-content and justify-content properties 👉 place-content

    I hope this helps! 😁

    Marked as helpful

    1
  • @okonks

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm most proud of the consistent progress I've made and how far I've come since I started. Each step forward has been a testament to my dedication and perseverance. However, looking back, I realize there are always areas for improvement. Next time, I aim to be more proactive in seeking feedback and incorporating it into my work. Additionally, I want to focus on refining my time management skills to ensure I'm making the most of every opportunity for growth

    What challenges did you encounter, and how did you overcome them?

    One of the challenges I encountered was trying to implement the box-shadow effect, as I wasn't familiar with it initially. However, thanks to resources like W3Schools, I was able to learn about it and understand how to apply it effectively.

    Another challenge I faced was accessing elements without specific IDs or class names. Through research and experimentation with GPT, I discovered techniques like descendant selectors in CSS, which allowed me to target and style elements based on their relationship to other elements in the HTML structure.

    Overall, these challenges served as valuable learning opportunities, reinforcing the importance of resourcefulness and persistence in problem-solving. By leveraging online resources and exploring alternative approaches, I was able to overcome obstacles and continue making progress in my journey

    Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    I recommend removing the margin: 8px that the body element has by default, as it can cause problems in the design,

    Remove the margins you added to the .container element, as there are better ways to center it, one of them is to use 👉 Flexbox.

    The text-align: center property on the .image element is unnecessary and has no effect.

    I don't recommend using width: 70px to make the Learning button take up less width since it is causing overflows, it is better that you do something like this:

    .background-yellow{
      display: inline-block;
      margin-bottom: 0;
    }
    

    inline-block will make the element occupy the space it needs and not 100% of its parent and margin-bottom will remove the margin at the bottom since after applying inline-block the margin will no longer collapse with the margin of the element below.

    Do not use the strong tag to make the text of an element bolder, the strong tag is used to indicate that the text has great importance or urgency and should not be used to style elements.

    I hope this helps! 😁

    Marked as helpful

    0
  • Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    To center the .card element you can use flexbox on its parent element in this case the body.

    body{
      display: flex;
      align-items: center;
      justify-content: center;
    }
    

    But for that to work the body has to be of sufficient height, you can solve this by applying the min-height: 100vh property. This will make the minimum height of the body 100% of the height of the device screen.

    And when it is already aligned, it will no longer be necessary to use margin: 100px in the .card element to move it a little to the center.

    You left the .btn-container element empty!

    Don't skip the headings, you are using an h5 where you should have used an h1.

    You can remove all the margin: 20px that you added to each element and instead use padding: 20px on the .card element, this will create an "inner margin" that separates the elements that it contains, and thus avoid adding the margin property to each element inside.

    I hope this helps! 😁

    Marked as helpful

    1
  • @ericcheng09

    Submitted

    What are you most proud of, and what would you do differently next time?

    first time combine html with css

    What challenges did you encounter, and how did you overcome them?

    unfamiliar with css. took time to google css usage.

    What specific areas of your project would you like help with?

    not sure

    Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    There is no need to add margin: 0 auto; to the .container since in the body you only need to add the justify-content: center; property to center the .container.

    The margin: 0 1em in the .card element is unnecessary.

    In the .text element you should use margin: 22px 10px instead of padding: 22px 10px, of course the same thing is achieved but the margin and the padding have different uses.

    Don't skip the headings, you are using a h2 when you should be using a h1.

    I hope this helps! 😁

    0
  • @complic8-coder

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am most proud of learning using more JavaScript features, while keeping up with the project's responsiveness.

    What challenges did you encounter, and how did you overcome them?

    Two challenges I encountered were removing the default required message, and using the provided email in the success message.

    I had to search for resources that will help me with the current project, and will likely help me in the future. Here are sources that have helped me through:

    What specific areas of your project would you like help with?

    Comments or feedback are appreciated 🤗

    Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    If you are not going to add html code you don't need to use innerHTML, you can use textContent instead.

    I recommend you add CSS classes to the signUp and success elements and manage the styles from your stylesheet, avoid adding styles using javascript.

    I hope this helps! 😁

    0
  • Kim 340

    @Mismisty

    Submitted

    What challenges did you encounter, and how did you overcome them?

    I had difficulty aligning the plus minus images to the paragraph, it looks ok, but I'm not completely satisfied with it. I also had difficulty with the box-shadow its hard to tell looking at the design images where the box-shadow is exactly.

    What specific areas of your project would you like help with?

    I would appreciate any and all feedback on this challenge, especially on the aligning of the plus and minus images. Thanks.

    Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    Leave the alt attribute empty if the image has no semantic meaning or is for decoration.

    I recommend you use the max-width property instead of the br tag to make the texts break.

    To make the plus and minus icons align with the text use the align-items: center; property on the .accordion element.

    I recommend that you read about Event Delegation, since you are adding an eventListener for each plus icon and minus icon, when you could do everything using a single click eventListener .

    I hope this helps! 😁

    Marked as helpful

    0
  • @mendesdomingosdev

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm proud that I didn't needed to much time to do it.

    What challenges did you encounter, and how did you overcome them?

    I'm not familiar with figma.

    What specific areas of your project would you like help with?

    How can I make the text break by himself instead using br tag?

    Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    You can use the max-width property on an element instead of the br element to make it break.

    You should add a more descriptive alt attribute, example: alt='Scan the qr code and go to Frontend Mentor site.

    I recommend using max-width: 90%; instead of width: 288px; in the img element

    You did amazing! I have nothing more to add.

    I hope this helps!

    Marked as helpful

    1
  • P
    Smaylen5 380

    @Smailen5

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm happy I managed to align the grid as I wanted, maybe I wrote too much code, but after several attempts, it's the only way I found.

    
      
        Work
      
    
      
        
      
    
    

    What challenges did you encounter, and how did you overcome them?

    I still can't understand why, even though the utility class is correct, it doesn't change the fill color of the SVGs.

    
    ### What specific areas of your project would you like help with?
    To write inside the HTML, I used this solution that I really don't like. I would like to simplify this part in the future.
    
    ```
    function daily(data) {
      workHours.innerText = data[0].timeframes.daily.current + "hrs";
      workPrevious.innerText = `Previous - ${data[0].timeframes.daily.previous}hrs`;
      playHours.innerText = data[1].timeframes.daily.current + "hrs";
      playPrevious.innerText = `Previous - ${data[1].timeframes.daily.previous}hrs`;
    ```
    
    Grego 1,050

    @Grego14

    Posted

    Hello! congratulations on completing the challenge!

    I recommend that you make the eventListener outside the forEach loop or make use of Event Delegation to improve the performance of the website.

    I also recommend that you move the fetch outside, since every time one of the buttons changes you are fetching the data.json again.

    The switch and those 3 functions are unnecessary...

    function update(data, btnValue){
      let text;
    
      if(btnValue === 'daily'){
        text = 'Previous'
      }else if(btnValue === 'weekly'){
        text = 'Last Week'
      }else if(btnValue === 'monthly'){
        text = 'Last Month''
      }
    
      workHours.innerText = data[0].timeframes[btnValue].current + "hrs";
      workPrevious.innerText = `${text} - ${data[0].timeframes[btnValue].previous}hrs`;
      playHours.innerText = data[1].timeframes[btnValue].current + "hrs";
      playPrevious.innerText = `${text} - ${data[1].timeframes[btnValue].previous}hrs`;
      studyHours.innerText = data[2].timeframes[btnValue].current + "hrs";
      studyPrevious.innerText = `${text} - ${data[2].timeframes[btnValue].previous}hrs`;
      exerciseHours.innerText = data[3].timeframes[btnValue].current + "hrs";
      exercisePrevious.innerText = `${text} - ${data[3].timeframes[btnValue].previous}hrs`;
      socialHours.innerText = data[4].timeframes[btnValue].current + "hrs";
      socialPrevious.innerText = `${text} - ${data[4].timeframes[btnValue].previous}hrs`;
      selfCareHours.innerText = data[5].timeframes[btnValue].current + "hrs";
      selfCarePrevious.innerText = `${text} - ${data[5].timeframes[btnValue].previous}hrs`;
    }
    

    Then you would use it like this:

      update(data, selectedIme)
    

    In the code above you would be replacing the daily, weekly and monthly functions with a single one.

    Remember that you can access a property of an object using square bracket notation too!

    obj[property]
    obj.property
    

    I didn't understand what you said about svgs... but there are some times where you need to change one of the elements within the svg for the color to change, example

    svg path{
      color: white;
    }
    

    If you need help with something else, remember that you can do reply.

    Sorry, I had to delete my last comment because I thought data returned 'daily', 'weekly' or 'monthly' and it didn't...

    I hope this helps!

    Marked as helpful

    1
  • bttrvng99 140

    @bttrvng99

    Submitted

    What are you most proud of, and what would you do differently next time?

    I learned how to use animations and :hover selector to highlight the links on the card

    What challenges did you encounter, and how did you overcome them?

    How to load images properly on Github pages by adding "./" to the beginning of the href in tag

    What specific areas of your project would you like help with?

    How to synchronize the shadow's animation with the highlighting of the link

    Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    If the image has no semantic meaning or is only for decoration you can leave the alt attribute empty.

    Don't skip the headings, you have an h1 and an h3, you should have an h2 before the h3.

    The transition must go in the element itself and not in the state of the element, example:

    .main{
      transition: box-shadow 0.1s ease-in-out;
    }
    
    h1{
      transition: color 0.1s ease-in-out;
    }
    

    not

    h1:hover{
      transition: color 0.1s ease-in-out;
    }
    

    To make the title change color when you hover over the card you can use this selector:

    .main:hover h1 {
      color: hsl(47, 88%, 63%);
    }
    

    There it would be selecting h1 when the .main has its hover state active.

    I hope this helps! 😁

    Marked as helpful

    0
  • @valeriahhdez

    Submitted

    What are you most proud of, and what would you do differently next time?

    It is very tempting these days to ask Chat GPT for a solution. This is a small and simple project, but an honest one.

    What challenges did you encounter, and how did you overcome them?

    Moving things around using padding and margin was a bit of a headache, how do more experienced programmers know how much to add or subtract from each one to put things where they should? It took me a lot of trial and error to find the numbers that gave me a solution I felt satisfied with.

    What specific areas of your project would you like help with?

    I would appreciate your input on these questions:

    1. Is the size of the component correct?
    2. How do I know if width: 290px; and height: 450px; for the white card are ok?
    3. I respected the style guidelines and left the font size for as 15px but this resulted in a slight change: the last 'to' is in the second line in the original, while my solution is in the third line. I played a lot with this font size, the padding, and the margin but I couldn't fix it.
    4. Any suggestions? Or should I just forget about that detail? How often do designers care about these types of details?

    I know those are a lot of questions, so thank you for even reading them!

    Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    Don't skip the headings, instead of using a h2 for the title use a h1.

    Use min-width: 100%; on the image to make it fill the entire size of its parent element.

    The margins in the img, h2 and p element are not necessary, you can remove them and to separate them from the sides use padding in the parent element.

    You can remove the position: relative; property as it is unnecessary in this case.

    Use the max-width property to set the text sizes, you can also use it to set the maximum size of the container max-width: 350px;.

    To make the image look better you can use this property 👉 object-fit.

    Now answering your questions:

    1. It's okay, I just recommend using min-width and min-height instead of width and height since in some cases it can cause overflows.

    2. When it doesn't cause overflows and looks good on both large and smaller screens, you'll know.

    3. After following the steps I mentioned above and using the max-width property on the p element you can make the word 'to' appear on the second line.

    4. I'm not a designer but I don't recommend that you worry too much about these types of details, just try to complete the challenge and don't focus too much on making it perfect. It would be better if you focused on accessibility, follow best practices and make the code scalable and reusable.

    I hope this helps! 😁

    Marked as helpful

    1
  • @TheWizCoder

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am proud to have completed this challenge and I aspire for more

    What challenges did you encounter, and how did you overcome them?

    I had problems formatting the images to the required size

    What specific areas of your project would you like help with?

    I would like tips on formatting photos correctly

    Grego 1,050

    @Grego14

    Posted

    Hello! 🎉 congratulations on completing the challenge! 🎉

    It is not necessary to add these properties to the .img-container element

    border-radius: 15px;
    overflow: hidden;
    

    Just add the border-radius to the image itself and that's it.

    To make the image take up the full height of its parent element you can use min-height: 100%;.

    Don't skip the headings, you are using a h5 before a h1, always remember to use from h1...h6.

    Nothing more to add, you did amazing!

    I hope this helps! 😁

    Marked as helpful

    0