Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P

    @arfarobs

    Submitted

    This is the first multi-page site that I have done on Frontend mentor. This is also the first time I have used an API in my projects. I thought that the website itself wasn't very challenging. However, the API was a bit of a challenge for me. Any feedback would be greatly appreciated.

    • How's my JS? Especially the map implementation?

    @Jorahhh

    Posted

    It looks nice Arthur. I was waiting for this!

    • I did as you did using two .css file but I'm not sure that it is correct.
    • The <form> selector is useful when you have to send data to the server (for example the registration module).
    • You could have used also the <br> to break the headings and match the design

    Just onother thing. if I were you I would have put the images with @2.jpg, they have a better resolution. With the images that you put the project loses a lot. Try with it.

    Marked as helpful

    1
  • Vanza Setia 27,855

    @vanzasetia

    Submitted

    Hello Everyone! 👋

    This was, in my opinion, the hardest newbie challenge. There were a lot of decorative images that I needed to take care of. I even ended up doing a revert commit to rewrite the styling. However, It's a nice and fun challenge that really tested my CSS skill, and I'm glad I was able to complete it. 😊

    I don't have any questions. However, feel free to give me any feedback or comments. 😉

    If you have finished this challenge and would like me to give feedback on it, please include a link to your solution. I would be glad to help you! 😀

    Thanks!

    Equalizer Landing Page | HTML CSS Sass

    #accessibility#bem#sass/scss#lighthouse

    3

    @Jorahhh

    Posted

    Wow Vanza, it seems as perfect as the original! Love the responsiveness here.

    By the way, some days ago I did this challenge too, and I have few "issues" to which I have not yet received an answer.

    Hope you can take a look: My challenge

    For a beginner like me would be great to have some feedback from someone more experienced.

    2
  • @Heph-zibah

    Submitted

    Community, I need your help.

    What I found difficult while building the project? I found it difficult to implement background images for each device(responsiveness). How do I put two images and background. Also, the favicon imahe, where am I to put it?

    Which areas of my code am I unsure of? I am not so sure about the margins and padding.

    Questions about best practices? While etsting the HTML markup, it mentioned something about a missing heading in the second section. Kindly look through and tell me what else I am missing.

    Thank you.

    @Jorahhh

    Posted

    Hey Abigail, to put two images in the backgroud, try with this:

    Background-image: url(“top bg), url(“bottom bg”); Background- repeat: no repeat, no repeat; Background-position: left top, right bottom; Background-size: contain;

    I did like this in my project, so I think it works 👌🏽

    …and oh, good job!

    Marked as helpful

    0
  • Ibtissam 260

    @Devibtissam

    Submitted

    Well, this is the first challenge I have done to practice CSS grid, any advice on how to improve and honest feedback will be welcome. Happy coding.

    @Jorahhh

    Posted

    I think you forgot to put the border radius at the whole grid.

    Just put in the main container:

    ‘Border-radius: 10px;’ (or less)

    And also in the mobile version in the first and last square.

    This time you have to do in the first square:

    Border-top-right-radius: 10px Birder-top-left-radius: 10px

    …and in the last one:

    Border-bottom-right-radius:10px; Border-bottom-left-radius: 10px;

    For the rest, it seems fine. Nice job! 😀

    Marked as helpful

    0
  • @Jorahhh

    Posted

    Wow! The responsiveness here is perfect! Love how it works. Good job!

    For the Background, try with:

    • background-image: url("top"), url("bottom")
    • 'background-repeat: no repeat, no repeat;'
    • 'background-position: left top, right bottom;'
    • 'background-size: contain;'

    I'm not sure it's correct but on my challenge it looks good (I'm still doing it). Hope it helps

    Marked as helpful

    1
  • @Jorahhh

    Submitted

    Used Grid for this challenge for the first time.

    Really though for me, and a I don't even know if it's a good code or if I could do It better. Any advice on how do it better would be appreciated.

    @Jorahhh

    Posted

    Ah! I think I did some mistakes in the @media queries with screen side dimensions.

    I put wrong min-max widths, 'cause from my pc (MacBook Air so its 1280px x 800px, I guess) it seems fine, but from others pc's not.

    Basically, on a bigger screen I see what I should see on a mobile device.

    Any suggestion on this?

    0
  • @Jorahhh

    Submitted

    Hi there! I'm Angelo a this is my first work ever. Just one month has passed since I've start learning HTML/CSS by myself, so I'm super open to every good/bad feedback.

    P.S. I'm from Italy, then I'm so so sorry for my bad English.

    @Jorahhh

    Posted

    I've just found out that I forgot to change the folder for the background images from the body. Argh!

    0